Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Use fieldSelector for target shoot command #129

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Use fieldSelector for target shoot command #129

merged 1 commit into from
Oct 22, 2019

Conversation

ialidzhikov
Copy link
Contributor

What this PR does / why we need it:
Use fieldSelector for gardenctl target shoot NAME.

Which issue(s) this PR fixes:
Fixes #127

Special notes for your reviewer:

Release note:

`gardenctl target shoot` performance is now improved.

@ialidzhikov
Use fieldSelector for target shoot command
2e0d2e8 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 21, 2019
vpnachev
vpnachev suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoot selection can be improved when seed is targeted

pkg/cmd/target.go Show resolved Hide resolved
vpnachev
vpnachev approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ialidzhikov ialidzhikov merged commit b2c833b into gardener-attic:master Oct 22, 2019
@ialidzhikov ialidzhikov deleted the enh/use-field-selector branch October 22, 2019 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Targeting shoots may take long
3 participants
@ialidzhikov @vpnachev @gardener-robot-ci-1